Skip to content

add qsort_r for unix, and qsort and qsort_s for windows #4677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add qsort_r for unix, and qsort and qsort_s for windows #4677

wants to merge 1 commit into from
+80 −0

Conversation

folkertdev
Copy link
Contributor

Description

Add qsort_r for apple, freebsd and netbsd targets, and qsort and qsort_s for windows targets.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Aug 28, 2025

Some changes occurred in OpenBSD module

cc @semarie

@semarie
Copy link
Contributor

semarie commented Aug 29, 2025 via email •
edited
Loading

@folkertdev
Copy link
Contributor Author

Sure, I moved the definition to src/unix/bsd/netbsdlike/netbsd/mod.rs, and I believe the semver entry was already correct.

@collinfunk
Copy link
Contributor

There is also a seperate and incompatible API that exists on older versions of FreeBSD before it was changed in 14.0 [1] [2]. Not sure if that needs to be handled here.

[1] https://www.gnu.org/software/gnulib/manual/html_node/qsort_005fr.html
[2] https://man.freebsd.org/cgi/man.cgi?query=qsort_r

@folkertdev
Copy link
Contributor Author

Right, fun, the argument order of the function pointer is swapped in those earlier versions

https://man.freebsd.org/cgi/man.cgi?query=qsort_r&manpath=FreeBSD+13.4-RELEASE

I've fixed that by moving the correct definition into src/unix/bsd/freebsdlike/freebsd/freebsd11/mod.rs and so on.

tgross35
tgross35 requested changes Sep 5, 2025
View reviewed changes
asomers
asomers suggested changes Sep 14, 2025
View reviewed changes
asomers
asomers approved these changes Sep 14, 2025
View reviewed changes
Copy link
Contributor

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is ok now. HOWEVER, I would like to wait to merge it until after #4685, #4690, and #4691 are resolved. The we can rebase this PR, and see if CI passes on FreeBSD.

@folkertdev
Copy link
Contributor Author

Well freebsd CI is happy now (all those 3 PRs got merged). Seems like something else is failing, I don't think that's due to this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 requested changes

+1 more reviewer

@asomers asomers asomers approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
O-macos O-unix O-windows S-waiting-on-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@folkertdev @rustbot @semarie @collinfunk @asomers @tgross35